search

nodeset-org / constellation

GNU General Public License v3.0
5 stars 0 forks source link

Upgrading doesn't work #324

Closed VVander closed 1 month ago

VVander commented 1 month ago
  1. (incorrectly) changed the operator distributor address to an implementation using directory.setAll()
  2. tried depositing into xRPL and it reverted
  3. changed the operator distributor address back to the original address using directory.setAll()
  4. upgraded the operator distributor implementation by calling upgradeTo() on the proxy, and the address of the implementation was verified as changed correctly
  5. The protocol still reverts when attempting to mint xRPL now

We need to know why this didn't work, and the best way to do this is to write tests to upgrade the protocol.

VVander commented 1 month ago

Turns out during step 2, the 0 address was set for the sanctions contract, which means all calls would fail.