search

nodeset-org / constellation

GNU General Public License v3.0
5 stars 0 forks source link

Recover locked ETH on minipool removal #330

Closed VVander closed 1 month ago

VVander commented 1 month ago

This checks on minipool removal whether there is ETH locked for that minipool and if so, recovers that ETH into the OD for usage. This is to cover the unlikely scenario where a NO attempts to front-run the deposit contract and the minipool is scrubbed.

Also cleans up a couple small things in SNA.

Addresses https://github.com/riley-holterhus-audit/nodeset-constellation/issues/13

VVander commented 1 month ago

blocked by #312

VVander commented 1 month ago

looks like bumping the RP contracts didn't fix the issues we're seeing with testing the close() function. Needs more investigation.