nodeset-org / constellation

GNU General Public License v3.0
5 stars 0 forks source link

Fix sanctioned address calls returning true from IERC20 functions when balances are not changed #375

Closed VVander closed 1 week ago

VVander commented 1 week ago

First, this ensures that we are compliant for the ERC20 interface even if an address is sanctioned. I.e. if a sanctioned address calls an ERC20 function, it will revert instead of silently reporting success even though balances weren't adjusted.

Second, this adds an admin toggle for allowing the sender and recipient of a deposit to be different (disabled by default for safety) in case legitimate integrating contracts require this for some reason.

This also adds some events, adds various comment updates, and lints WETHVault.sol.