nodeset-org / constellation

GNU General Public License v3.0
6 stars 0 forks source link

Add parameter to prevent Constellation from accepting deposits when there is no rETH available to match #416

Closed VVander closed 1 week ago

VVander commented 1 month ago

Currently, Constellation will accept any amount of deposits, so long as the xrETH:xRPL TVL ratio is within the bounds of maxWethRplRatio and minWethRplRatio. This allows for an unlimited amount of queued minipools to be created (up to the maxValidators parameter per NO), but queued minipools do not earn rewards and therefore act as an APR drag for xrETH/xRPL.

To prevent APR drag, Constellation's WETH vault should have new boolean parameter called queueableDepositsLimitEnabled. If set to false, the protocol acts as it does now. If set to true, WETHVault.deposit() will check a new requirement: if the pairable rETH > 0, accept deposits, otherwise revert.