nodeshift-archived / centos7-s2i-nodejs

DEPRECATED OpenShift S2I builder images for Node.js ✨
Apache License 2.0
33 stars 55 forks source link

consider adding NODE_PENDING_DEPRECATION flag #60

Closed lance closed 6 years ago

lance commented 6 years ago

This will warn us of any new Buffer() usage which will be deprecated in 10.0.0 one month from now.

lance commented 6 years ago

The flag that we would add to our s2i run script would be --pending-deprecation. But since it is possible for users to set this in the environment using NODE_PENDING_DEPRECATION=1 it seems unnecessary to have the flag always on.