search

nodeshift-archived / ubi8-s2i-web-app

Apache License 2.0
26 stars 28 forks source link

using Yarn in the "run" phase #43

Closed lholmquist closed 5 years ago

lholmquist commented 5 years ago

Recently, yarn was removed from our base node image, and instead we are doing npx yarn install in the assemble phase. So for this image we've updated our assemble phase to do a similar thing, if yarn in enabled.

In the run script, a user is allowed to override what is run with the $NPM_RUN environment variable. In the Using For development section of the readme, we show overriding that variable with yarn start. this will actually fail since yarn is no longer installed.

We have some options here.

  1. We update the README to use npx, NPM_RUN="npx yarn start"

  2. We could add npx to the run script, so that might look like npx $NPM_RUN

lholmquist commented 5 years ago

We are going to go with Option 1, just adding in some readme updates