search

nodeshift-archived / ubi8-s2i-web-app

Apache License 2.0
26 stars 28 forks source link

When `YARN_ENABLED=true`, `NPM_BUILD` override doesn't run #63

Closed ponddesign closed 4 years ago

ponddesign commented 4 years ago

I noticed when we have YARN_ENABLED=true, we lose the ability to use the NPM_BUILD override variable:

https://github.com/nodeshift/ubi8-s2i-web-app/blob/1a457eccfff9cedbf6f68a1b624a211addd89af6/s2i/assemble#L60-L63

Would it be possible to have a YARN_BUILD (and YARN_RUN) override similar to the NPM_ counterparts? Alternatively, perhaps the code could allow the override to run regardless of whether we're using NPM or Yarn.

lholmquist commented 4 years ago

Thanks for the PR, the images on docker hub should be updated