nodeshift-archived / ubi8-s2i-web-app

Apache License 2.0
26 stars 28 forks source link

Does the openshift pipeline fail if npm audit finds high vulnerability #88

Open shakeelosmani opened 3 years ago

shakeelosmani commented 3 years ago

I am using the this as a s2i builder image for Tekton pipelines. However at the moment post npm install it is failing after it prints out npm aduit message with high vulnerability. Is that the case ? or there is a different issue that is actually not getting printed perhaps for this https://github.com/nodeshift/ubi8-s2i-web-app/issues/

lholmquist commented 3 years ago

npm audit shouldn't have anything to do with failures. it is probably something else and it is being hidden becuase of that other issue.

If i get time today, i can release an updated version removing the silent option

lholmquist commented 3 years ago

you should be able to use this env var to change the npm output level https://github.com/nodeshift/ubi8-s2i-web-app/pull/80