Closed helio-frota closed 3 years ago
@helio-frota perhaps we can just grab the last 3-4 lines of output (and ignore the rest)
+ node-rdkafka@2.10.1
added 4 packages from 10 contributors and audited 4 packages in 54.055s
found 0 vulnerabilities
We can also introduce a --verbose
flag for anyone that does want to see all the compilation output.
We can also introduce a --verbose flag for anyone that does want to see all the compilation output.
I think we should suppress (if possible) all the native-addon output because it cancels/nullify the npcheck feature that is to show the PASS
information to the output.
// First part
Checking if module has appropriate testing PASS
Checking maintenance metrics PASS
Running checks on node-rdkafka
Checking if it's deprecated on NPM PASS
Checking if github repository is archived PASS
Checking top-level license PASS
native-addon-output-here....
// Second part
Checking license of bindings@1.5.0 PASS
Checking license of file-uri-to-path@1.0.0 PASS
Checking license of nan@2.14.2 PASS
Checking if module has appropriate testing PASS
Checking maintenance metrics PASS
NPCheck Report
problems: 0 (errors: 0 - warnings: 0)
Depending on the end-user terminal scroolback size, it will be impossible to see the first part of npcheck results. If the end-user really wants to see the compilation output of a native-addon, I guess that should be done directly on the native-addon module by running npm install, not in npcheck. Makes sense?
Yeah, sounds good!
Closing it is already solved