Bugfix for 8.20.0 - Githubissues

nodeshift / opossum

Node.js circuit breaker - fails fast ⚡️

https://nodeshift.dev/opossum/

Apache License 2.0

1.33k stars 107 forks source link

Bugfix for 8.20.0 #896

Closed daan944 closed 1 month ago

daan944 commented 1 month ago

Bugfix: coalesce re-used empty cachekey when cache was not used. Bugfix: emit fire when circuitbreaker is disabled.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11555588227

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 98.328%

Totals
Change from base Build 11555340370:	0.007%
Covered Lines:	401
Relevant Lines:	402

💛 - Coveralls

lholmquist commented 1 month ago

We just merged #895 which fixes that fire issue. could you remove that part from this PR and just make this PR resolve the "Bugfix: coalesce re-used empty cachekey when cache was not used."?

daan944 commented 1 month ago

Of course!