search

nodesign / weio

weio
http://we-io.net
128 stars 35 forks source link

add run without main.py support & fix print of long strings in IDE console #143

Closed manuio closed 9 years ago

drasko commented 9 years ago

This touches system. We must re-test before merge (I prefer not to merge this one automatically) @ukicar test this also on your side, please.

drasko commented 9 years ago

Why are you checking here: https://github.com/manuIO/weio/blob/next/weioPlayer.py#L133 if default main.py exists, when you know it exits?

Everything else looks good to me (but I have to test on the board).

manuio commented 9 years ago

Yes right, is not really useful... I forgot to remove this "if". Let me change that!

drasko commented 9 years ago

Please do and re-check everything on the board, with various scenarios. This is very sensitive part you are changing. @ukicar has to re-check also, and he will do this over the WE.

Changes looks OK, but you are touching a core system, and I am very afraid not to break something.

manuio commented 9 years ago

I've tested with several examples and various scenarios and it works good for me! I hope that @ukicar will get the same result!

I've noticed strange behaviors running i2c example. I get same strange behavior without lasts commits, so I think that is a real bug with I2C bus: https://github.com/nodesign/weio/issues/145

manuio commented 9 years ago

can be closed?

manuio commented 9 years ago

I've done manually new PR to prevent conflict: https://github.com/nodesign/weio/pull/181 Can be closed!