search

nodesign / weio

weio
http://we-io.net
128 stars 35 forks source link

fix height IDE preview bug #146

Closed manuio closed 9 years ago

drasko commented 9 years ago

@nmarcetic can you please review this before merge, please.

manuio commented 9 years ago

@nmarcetic I've only changed this line: https://github.com/manuIO/weio/commit/339875062ed6c0d3d9c40722e0133a0fab4aa007#diff-b62ecd8d7fee6978acb0ddda272544f9R436

The others modification are onely some clean-up.

I've tried some methods to set "height" of "iframeContainerIndex" at 100% like in "iframeContainer" but it doesn't work... Maybe you know better solution ?

nmarcetic commented 9 years ago

@manuIO With current structure this is less painful approach. Thanks!

manuio commented 9 years ago

@nmarcetic Cool! @drasko If is good for everyone this issue can be closed: https://github.com/nodesign/weio/issues/43