Fix version checking for Debian repo for future versions.

nodesource / ansible-nodejs-role

Ansible Role for Node.js Binary Install

MIT License

131 stars 47 forks source link

Fix version checking for Debian repo for future versions. #20

Closed mtpereira closed 7 years ago

mtpereira commented 8 years ago

Hello,

With this solution, new versions of Node will be covered, assuming that the repo naming convention sticks.

What do you think @wolfeidau? Does this fix #19 ?

wolfeidau commented 8 years ago

@mtpereira This looks great, would be nice if you based it on master rather than my branch? So I can merge it there.

Cheers.

mtpereira commented 8 years ago

Hello,

Ok, I'll fix those things.

My thinking on opening a PR to your feature branch was that you could merge it your branch, adapt as you see fit and then carry on with merging the original PR.

As for the variable, I always feel safer my prepending every var name with the name of the role, in order to avoid collisions.

Thank you.