nodesource / docker-node

Dockerfiles for building docker images with the NodeSource Node.js binaries baked in.
MIT License
192 stars 22 forks source link

node v4 for CentOS 7 x86_64 #33

Closed focusaurus closed 9 years ago

focusaurus commented 9 years ago

nodesource rpms are available in pub_4.x/el/7/x86_64 but I don't see any corresponding docker images on dockerhub. Specifically looking for 4.2.1 but anything 4.x would be nice.

retrohacker commented 9 years ago

Hey @focusaurus, I added these to the repo earlier this week but they are failing the integration tests.

I've been working on getting the build time down on these so that we can iterate on them faster (currently it takes 8 hours to test!).

I should have something working for you this week.

retrohacker commented 9 years ago

Hey @focusaurus, the latest versions of Node are now available for both centos and fedora. Cheers!

focusaurus commented 9 years ago

Great, thanks! I see them listed on hub.docker.com in the HTML but pulling says there is no such tag:

docker pull nodesource/centos7:4.2.2
Pulling repository docker.io/nodesource/centos7
Tag 4.2.2 not found in repository docker.io/nodesource/centos7

Am I missing a step or something?

focusaurus commented 9 years ago

Yeah, hmm, the newer 4.x tags are not listed here: https://hub.docker.com/r/nodesource/centos7/tags/

retrohacker commented 9 years ago

Super weird. Pushes to this repository trigger a rebuild of the cenots7-base image, which in turn triggers a rebuild of the centos7 images. The base image completed this morning, but the other images have taken over 6 hours to build. I'll open a support ticket on Docker Hub for this and try and get it resolved.

In the meantime, if this is on your critical path, you can use these images locally via:

  1. Clone this repository
  2. run docker build -t "nodesource/centos7-base" . in ./base/centos/7/
  3. run docker build -t nodesource/centos7:4.2.2 in /centos/7/node/4.2.2/

I'll post updates here as they come.

retrohacker commented 9 years ago

docker_images1

v4 should now be available.

focusaurus commented 9 years ago

Yup, looks good from my side, too. Thanks!

retrohacker commented 9 years ago

:heart: