search

nodesource / docker-node

Dockerfiles for building docker images with the NodeSource Node.js binaries baked in.
MIT License
192 stars 22 forks source link

apt-get --no-install-recommends #8

Closed retrohacker closed 9 years ago

retrohacker commented 9 years ago

Are the recommended packages necessary?

lovell commented 9 years ago

Hi @wblankenship, thanks for maintaining these Dockerfiles!

The git package has an recommends dependency on ssh-client.

The use of Git URLs as dependencies in package.json can result in a failed attempt to use the missing ssh command when running npm install. This is always the case when using the common Github user/repo format.

Perhaps installing ssh-client via apt-get in the Dockerfile would be enough for this example?

retrohacker commented 9 years ago

Hey @lovell,

You are absolutely right. We should be able to add ssh-client to this line to fix for debian and ubuntu, https://github.com/nodesource/docker-node/blob/master/dockerfiles/debian.js#L48

Will take a look at this for our RHEL flavored images as well.

lovell commented 9 years ago

Thanks @wblankenship.

Whilst you're looking at this, I think the RHEL images also need the equivalent of build-essential to be able to compile native addons, perhaps by including (the dependency tree of) a package like g++.

retrohacker commented 9 years ago

Hey @lovell and @koresar,

This repo had quickly become unweildy. I just landed a PR (https://github.com/nodesource/docker-node/pull/34) that greatly reduced the build times for running integration tests locally.

I've got a proposal for adding ssh-client and the equivalent to build-essentials, just waiting for the tests to pass and will open a PR before the EOD.

koresar commented 9 years ago

I wish GitHub had the "reactions" feature of the Slack. In other words - :+1:

On Tue, 3 Nov 2015 08:20 William Blankenship notifications@github.com wrote:

Hey @lovell https://github.com/lovell and @koresar https://github.com/koresar,

This repo had quickly become unweildy. I just landed a PR (#34 https://github.com/nodesource/docker-node/pull/34) that greatly reduced the build times for running integration tests locally.

I've got a proposal for adding ssh-client and the equivalent to build-essentials, just waiting for the tests to pass and will open a PR before the EOD.

— Reply to this email directly or view it on GitHub https://github.com/nodesource/docker-node/issues/8#issuecomment-153160069 .

lovell commented 9 years ago

Great, thanks both!