search

nodesource / ncm-ci

NCM for CICD systems
https://nodesource.com/products/certified-modules
MIT License
8 stars 2 forks source link

Add a timeout to `fetch()` + configurable environment variable #24

Open bnb opened 6 years ago

bnb commented 6 years ago

This PR adds a timeout to the fetch() call in /bin/ncm-ci.js. Also adds the NCM_TIMEOUT environment variable, which can be used to set a custom timeout time (2 minutes by default).

bnb commented 6 years ago

LGTM @juliangruber!

As a note, I used the all caps because of a similar environment variable in the GraphQL code 😅

juliangruber commented 6 years ago

As a note, I used the all caps because of a similar environment variable in the GraphQL code 😅

oops! consistency :D