search

nodesource / nsolid

N|Solid Runtime
Other
61 stars 4 forks source link

Add test for UV_EINVAL on C++ API #172

Open RafaelGSS opened 3 months ago

RafaelGSS commented 3 months ago

"Another task to do could be adding a test that actually checks the UV_EINVAL by exercising the C++ API, as with the change you just proposed, the JS API will behave differently" - @santigimeno

RafaelGSS commented 3 months ago

As I said in https://github.com/nodesource/nsolid/pull/173#issuecomment-2307647851. It might require creating a proper cctest setup for SharedEnvInst and so on, right?

santigimeno commented 3 months ago

Easier to implement it as an addon. Take a look or modify https://github.com/nodesource/nsolid/blob/node-v20.x-nsolid-v5.x/test/addons/nsolid-heap-sampler