nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
36 stars 11 forks source link

fix jsonl line parsing #264

Closed grantleehoffman closed 6 months ago

grantleehoffman commented 6 months ago
codecov[bot] commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (66d0953) 96.05% compared to head (958dcb1) 96.01%.

Files Patch % Lines
nodestream/pipeline/extractors/files.py 90.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ========================================== - Coverage 96.05% 96.01% -0.05% ========================================== Files 133 133 Lines 3959 3968 +9 ========================================== + Hits 3803 3810 +7 - Misses 156 158 +2 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <90.00%> (-0.05%)` | :arrow_down: | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <90.00%> (-0.05%)` | :arrow_down: | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `95.92% <90.00%> (-0.05%)` | :arrow_down: | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <90.00%> (-0.05%)` | :arrow_down: | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <90.00%> (-0.05%)` | :arrow_down: | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `95.92% <90.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

angelosantos4 commented 6 months ago

I think maybe also add a test for jsonl file types in the S3 Extractor test files: tests/unit/pipeline/extractors/stores/aws/test_s3_extractor.py

That replicates the JSON decode error when these changes are undone.