Closed grantleehoffman closed 6 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
66d0953
) 96.05% compared to head (958dcb1
) 96.01%.
Files | Patch % | Lines |
---|---|---|
nodestream/pipeline/extractors/files.py | 90.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think maybe also add a test for jsonl file types in the S3 Extractor test files: tests/unit/pipeline/extractors/stores/aws/test_s3_extractor.py
That replicates the JSON decode error when these changes are undone.
StringIO
type returns typebytes
, using iterator ofStringIO.readlines()
returns typestr