nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
36 stars 11 forks source link

Correct batchsize to be batchSize #266

Closed zprobst closed 6 months ago

zprobst commented 6 months ago

This was a typo from the query. This value is being ignored because of casing.

The reason this value should can be set is that large transactions can cause major turmoil when it its updating with large transactions of relationships (Especially against large data sets).

See here in the docs: https://neo4j.com/docs/apoc/current/overview/apoc.periodic/apoc.periodic.iterate/

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (22123a2) 96.01% compared to head (b2343aa) 96.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #266 +/- ## ======================================= Coverage 96.01% 96.01% ======================================= Files 133 133 Lines 3968 3968 ======================================= Hits 3810 3810 Misses 158 158 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <ø> (ø)` | | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <ø> (ø)` | | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `95.92% <ø> (ø)` | | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `?` | | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `96.01% <ø> (ø)` | | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `95.92% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grantleehoffman commented 6 months ago

Good Catch! 🎉