search

nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
36 stars 11 forks source link

Fix nodes with key properties of differing types crashing nodestream #275

Closed zprobst closed 5 months ago

zprobst commented 6 months ago

This worked more by coincidence than by design. The key needs to be ordered by the pairs not just the values.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.45%. Comparing base (8d4acc6) to head (735b97c). Report is 7 commits behind head on 0.12.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.12 #275 +/- ## ======================================= Coverage 97.45% 97.45% ======================================= Files 139 139 Lines 4557 4557 ======================================= Hits 4441 4441 Misses 116 116 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.45% <100.00%> (ø)` | | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.45% <100.00%> (ø)` | | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.40% <100.00%> (ø)` | | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.45% <100.00%> (ø)` | | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.45% <100.00%> (ø)` | | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.40% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.