search

nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
36 stars 10 forks source link

Feat/add allow create flag to source nodes v2 #292

Closed yasonk closed 4 months ago

yasonk commented 4 months ago

When source node of a pipeline is fully controlled by another pipeline, we may not want to create new nodes.

For example, if we already have a pipeline that creates all the Persons from our employee database, a new pipeline that attaches address to Persons may want avoid creating "Person" nodes simply because the address for that person already exits.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.69%. Comparing base (a397ef3) to head (bbd64ee).

Files Patch % Lines
nodestream/model/desired_ingestion.py 96.15% 1 Missing :warning:
nodestream/model/graph_objects.py 91.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #292 +/- ## ========================================== + Coverage 97.58% 97.69% +0.10% ========================================== Files 139 139 Lines 4601 4639 +38 ========================================== + Hits 4490 4532 +42 + Misses 111 107 -4 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.69% <97.22%> (+0.10%)` | :arrow_up: | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.69% <97.22%> (+0.10%)` | :arrow_up: | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.64% <97.22%> (+0.10%)` | :arrow_up: | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.69% <97.22%> (+0.10%)` | :arrow_up: | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.69% <97.22%> (+0.10%)` | :arrow_up: | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.64% <97.22%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.