search

nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
36 stars 10 forks source link

Fix Migrator Resiliency Issues #312

Closed zprobst closed 2 months ago

zprobst commented 2 months ago

This PR introduces two changes to migrations:

  1. Fixes an issue where properties that have been promoted to keys are considered dropped.
  2. Fixes an issue where the migration lock is not released after a failure. This means that in the cases where a spurious error occurs, the migrations cannot be reran without manually removing the lock.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.70%. Comparing base (fed9fa1) to head (64f695d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #312 +/- ## ======================================= Coverage 97.70% 97.70% ======================================= Files 139 139 Lines 4653 4661 +8 ======================================= + Hits 4546 4554 +8 Misses 107 107 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.70% <100.00%> (+<0.01%)` | :arrow_up: | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.70% <100.00%> (+<0.01%)` | :arrow_up: | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.65% <100.00%> (+<0.01%)` | :arrow_up: | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.70% <100.00%> (+<0.01%)` | :arrow_up: | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.70% <100.00%> (+<0.01%)` | :arrow_up: | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.65% <100.00%> (+<0.01%)` | :arrow_up: | | [3.12-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.70% <100.00%> (+<0.01%)` | :arrow_up: | | [3.12-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.70% <100.00%> (+<0.01%)` | :arrow_up: | | [3.12-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.65% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.