nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
36 stars 10 forks source link

Interpreter Schema Generation v2 #333

Closed angelosantos4 closed 1 month ago

angelosantos4 commented 1 month ago

In this PR, we rework the way that the interpreter generates a schema based on the underlying interpretations.

Changes:

Additional work/Unsolved Problems:

For instance:

switch:
  key: A
    - some relationship A
  key: B
    - some Relationship B 
switch:
  key: A 
    - some source node A
  key: B
    - some source node B 

In the schema generation, source node A will involve both relationship A and relationship B, even though it is not possible for source node A to have relationship

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.87%. Comparing base (ee0c427) to head (c6d3927).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #333 +/- ## ========================================== + Coverage 97.80% 97.87% +0.07% ========================================== Files 143 144 +1 Lines 5001 5136 +135 ========================================== + Hits 4891 5027 +136 + Misses 110 109 -1 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (+0.07%)` | :arrow_up: | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (+0.07%)` | :arrow_up: | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.83% <100.00%> (+0.07%)` | :arrow_up: | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (+0.07%)` | :arrow_up: | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (+0.07%)` | :arrow_up: | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.83% <100.00%> (+0.07%)` | :arrow_up: | | [3.12-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (+0.07%)` | :arrow_up: | | [3.12-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (+0.07%)` | :arrow_up: | | [3.12-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.83% <100.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.