nodestream-proj / nodestream

A Declarative framework for Building, Maintaining, and Analyzing Graph Data
https://nodestream-proj.github.io/docs/
Apache License 2.0
37 stars 11 forks source link

Minor Fix to Local Credential Logic #336

Closed zprobst closed 3 months ago

zprobst commented 3 months ago

We were accidentlly supplying args intended for boto3 to botocore. In this case, we do not need to supply those args at all, we just need to get the credentials.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.87%. Comparing base (2474f4d) to head (494c0eb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #336 +/- ## ======================================= Coverage 97.87% 97.87% ======================================= Files 144 144 Lines 5141 5141 ======================================= Hits 5032 5032 Misses 109 109 ``` | [Flag](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | Coverage Δ | | |---|---|---| | [3.10-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (ø)` | | | [3.10-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (ø)` | | | [3.10-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.83% <100.00%> (ø)` | | | [3.11-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (ø)` | | | [3.11-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (ø)` | | | [3.11-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.83% <100.00%> (ø)` | | | [3.12-macos-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (ø)` | | | [3.12-ubuntu-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.87% <100.00%> (ø)` | | | [3.12-windows-latest](https://app.codecov.io/gh/nodestream-proj/nodestream/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj) | `97.83% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodestream-proj#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.