Update canvas dependency to be compatible with v1.x

nodetiles / nodetiles-core

Render Leaflet compatible map tiles and UTFGrids using node-canvas on Heroku

BSD 3-Clause "New" or "Revised" License

47 stars 22 forks source link

Update canvas dependency to be compatible with v1.x #78

Closed Mr0grog closed 9 years ago

Mr0grog commented 9 years ago

In #77, @waissbluth tripped over a dependency on an out-of-date version of Canvas that doesn’t build on the latest OS X :(

Rather than keep updating the dependency every time Canvas does a release, I’ve changed our dependency to work with any Canvas 1.x version. Since I believe Canvas uses semver, this should be safe. All our tests still pass (including new rendering tests in bug-10-image-tests).

bensheldon commented 9 years ago

:+1:

...though ugh for Travis crashing out on installing Canvas module

Mr0grog commented 9 years ago

I hope you are also enjoying an inbox full of me fighting with Travis right now, too ;)

coveralls commented 9 years ago

Coverage remained the same at 18.35% when pulling 8c7d6327e882b86807425c2a77b47d90a13069d0 on 77-canvas-out-of-date into f15d4a6d0207c9a91ab42279bc041ed53ca5004d on master.

Mr0grog commented 9 years ago

Ok, going to merge, bump version, and publish.