Move header and footer bits inside the shell

nodezoo / nodezoo-web

nodezoo.com front end

MIT License

12 stars 61 forks source link

Move header and footer bits inside the shell #20

Closed mcdonnelldean closed 8 years ago

mcdonnelldean commented 8 years ago

This means we end up with

<div id=app>
 <div className=shell>
  ... Whole site here

I'm not massively happy about this but I need to speak to people with more react experience to fix. For now this will allow @thefoxis to keep the design semantic so we can just pull the two top divs when we figure out the best way to do it.

@ckiss I'll get you to do this for Nodezoo please.

mcdonnelldean commented 8 years ago

@ckiss Hold till Monday

ckiss commented 8 years ago

done by: https://github.com/rjrodger/nodezoo-web/pull/23