search

nodezoo / nodezoo-web

nodezoo.com front end
MIT License
12 stars 61 forks source link

Use Prepublish to build the assets #35

Closed mcdonnelldean closed 8 years ago

mcdonnelldean commented 8 years ago

When we move to dot version we will need to prebuild the site on publish. Will need to use this for it to work correctly. https://www.npmjs.com/package/in-publish

mcdonnelldean commented 8 years ago

The /dist folder is git ignored so we will need an .npmignore to override this as far as I know.

vislamov commented 8 years ago

At this point npm publish not publishing dist directory to npm even with it included in files array in package.json or with .npmignore ommited in it. Needs more digging on the subject.

mcdonnelldean commented 8 years ago

So i think this is because it is ignored in the .gitignore. Yeah dig away see what you come up with.

Kindest Regards,

Dean

On 5 Apr 2016, at 16:10, Vladimir Islamov notifications@github.com wrote:

At this point npm publish not publishing dist directory to npm even with it included in files array in package.json or with .npmignore ommited in it. Needs more digging on the subject.

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub

mcdonnelldean commented 8 years ago

@vislamov @AdrianRossouw We need to chat about this. Basically the .npmignore needs to allow dist for publishing but it also breaks our fuge config. Any more ideas on how to progress this?

AdrianRossouw commented 8 years ago

IIRC it will fall back to gitignore if there is no npmignore. I removed the npmignore, because it only really had the ~* in there.

so just touch and commit the .npmignore?

mcdonnelldean commented 8 years ago

I think that should work. I'm pushing releases today so I can check?

Kindest Regards,

Dean

On 10 Apr 2016, at 03:34, Adrian Rossouw notifications@github.com wrote:

IIRC it will fall back to gitignore if there is no npmignore. I removed the npmignore, because it only really had the ~* in there.

so just touch and commit the .npmignore?

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub

vislamov commented 8 years ago

I was trying with .npmignore, the doc says if it's omitted in .npmingnore then it should take it, but didn't work for me, please give it a shot, may be I didn't do it right.

mcdonnelldean commented 8 years ago

Closed as complete.