search

nodezoo / nodezoo-web

nodezoo.com front end
MIT License
12 stars 61 forks source link

Tests Needed #89

Open powerbrian opened 8 years ago

Georgette commented 8 years ago

So last time I checked, Lab is server side. Certainly don't want to test, even reducers, with a server side framework because it is an entirely different environment.

I'd like to bring in Mocha+Chai+JSDOM(maybe) for front-end testing, which is the typical react-testing suite. I've never tried it, but would like to write a few tests just to get things rolling.

Alternatively, react now has shallow rendering in their testing utils, so we could use Tape -- but shallow render is new, and you might want something with more how-to refs.

@mcdonnelldean

mcdonnelldean commented 8 years ago

Sounds solid!

Kindest Regards,

Dean

On 25 Apr 2016, at 01:25, Gege Pincin notifications@github.com wrote:

So last time I checked, Lab is server side. Certainly don't want to test, even reducers, with a server side framework because it is an entirely different environment.

I'd like to bring in Mocha+Chai+JSDOM(maybe) for front-end testing, which is the typical react-testing suite. I've never tried it, but would like to write a few tests just to get things rolling. @mcdonnelldean

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

Georgette commented 8 years ago

So I just had enough time to get things set up with mocha-chai, leaving behind code coverage setup (maybe instanbul) and travis integration.

Also, and this should be a long term goal, is to integrate with selenium because although most tests cases can be brought against the current virtual dom mock, the one thing we can't ensure if that any of our javascript doesn't break in a particular browser. Selenium also will take screenshots on builds (so we can easily check css support) and some other cool things -- but its really not a necessity. This is simply a step of complete rigor.