Incorrect parameter type being specified to super constructor of AvaxConnector

fortsoftware commented 2 years ago

Issue ticket number and link

None

Description

EthConnector expects a ChainUrl object, but a string (url) is being specified. I updated the code so that it passes down the url wrapped in a ChainUrl object.

The other way to go would have been to construct the ChainUrl object with the correct url right at connector_utils.create_connectors(), but i did it this way since it produces the smallest change set.

Type of change

Please delete option that is not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

nodiesBlade commented 1 year ago

Hey @fortsoftware

Thanks for the PR. We've instead opted for https://github.com/baaspoolsllc/nodies_monitoring/pull/28 which is more or less the same thing, except with different types passed. Additionally, we added type hinting to our params to ensure this doesn't happen. In the future, we will write unit tests as well :)

fortsoftware commented 1 year ago

Hey @fortsoftware

Thanks for the PR. We've instead opted for #28 which is more or less the same thing, except with different types passed. Additionally, we added type hinting to our params to ensure this doesn't happen. In the future, we will write unit tests as well :)

Awesome! Cool that you added type hinting!

nodiesorg / nodies_monitoring