When a subgraph, with a Mixer node in it, is collapsed, the Mixer node stops functioning

nodos-dev / nodos

0 stars 0 forks source link

When a subgraph, with a Mixer node in it, is collapsed, the Mixer node stops functioning #18

Open ugurtur opened 1 month ago

ugurtur commented 1 month ago

Reality 5.4.sp2.b805

Reproduction:

Add AjaIn and AjaOut nodes.
Add Mixer node.
Connect AjaIn => channel1 of Mixer node => AjaOut
Select AjaIn and Mixer nodes, and from the menu, select "Collapse into graph"
Expected result: Nothing changes in the output video.
Actual result: the output video disappears.
Expand the graph, and the output video comes back.

Screen recording: https://github.com/user-attachments/assets/7b8ce933-1598-40ed-a9ed-fbfd098a7a56

Jira: R5-774

shamilatesoglu commented 3 days ago

The Mixer node decides which textures to bind using pin connections. With nos.sys.vulkan version 5.9, we added a "IsStockTexture" function to the API. Instead of using OnPinConnected/Disconnected node callbacks, this should be used to check whether the input texture is connected. That should fix the problem.