nodu / teamster

Team Management
0 stars 0 forks source link

Request for additional changes #2

Open palaparthi opened 1 week ago

palaparthi commented 1 week ago

Thanks for dockerizing the project, I was able to get it to work. I have few change requests

  1. Server side validations are missing. For example phone number, can you please add them with tests?
  2. Can you add pagination for the list view.
nodu commented 1 week ago

Heya @palaparthi , Glad you were able to get the project running via Docker.

  1. I've added additional validations and aligned these with the UI.
  2. To help with your pagination testing, I've added a Seed button at the top of the initial UI view.

I've pushed up new images, so you should just have to pull and run them again:

docker pull nodu/teamster:ui
docker pull nodu/teamster:api

docker run --rm -p 8000:8000 nodu/teamster:api
docker run --rm -p 80:3000 nodu/teamster:ui
palaparthi commented 1 week ago

Thanks for adding the pagination, the validations still doesn't seem to be working as expected. I am able to add a user with the same phone number, see below.

Screenshot 2024-10-25 at 12 28 23 PM

nodu commented 1 week ago

@palaparthi Phone numbers are now unique. Give it a go. New images have been pushed.