Closed kaero closed 11 years ago
We must keep compatibility (compile POST
, PUT
and PATCH
requests body from query
and body
with body
(?) in prior) or bump minor version.
I guess it's better to write synthetic tests first. node-request
tests may be taken as an example.
I've a much progress with tests now. You can cook the fix and we'll apply it when tests will be done (;
Ok, nice. Can help with the tests, when theirs skeleton would be ready.
I'd discussed this issue with @webstalk3r, and I decide to compile request body always when it's provided in the options.body
and so asker mustn't merge body
and query
options. Using body for GET
or DELETE
methods may be not so RESTful, but it's not meaningful if you server can correctly parse the request and reponse to it.
Update: issue title was "compile request body from
query
option instead ofbody
"