search

nodules / asker

http.request wrapper with gzip, request retries and http.Agent tuning
MIT License
93 stars 11 forks source link

Allow any http(s) options to be passed #118

Closed narqo closed 8 years ago

narqo commented 8 years ago

Currently we don't support for passing options that don't have their equivalent in DEFAULT_OPTIONS hash.

This:

  1. limits us in options we are allowed to use:
    • for example there is no ability to specify ca root certificate now;
  2. makes us to do additional checks that are to be done inside http(s) modules as well;

cc @kaero

narqo commented 8 years ago

Note that, this actually should be considered as a bug fix, as asker<1.0.0 behaved in the same way. And this behaviour has been broken in 1.0.0.

Flackus commented 8 years ago

Seems nice. :8ball:

narqo commented 8 years ago

:fire: