Closed doochik closed 8 years ago
Looks like this'll make #92 impossible to implement.
What you mean under "request abort"? Request
hasn't a public method to abort a request.
@kaero I believe it's about this peace: https://github.com/nodules/asker/blob/acc28e620c5cf1ef50b31bb470f8e94984a43bea/lib/asker.js#L592-L604
yep
@doochik proposed changes looks acceptable for me, feel free to pr :)
Here it is :) https://github.com/nodules/asker/pull/123
+ asker@1.0.5
In some cases
data
event can be fired after request abort. Asker continues buffering response (https://github.com/nodules/asker/blob/acc28e620c5cf1ef50b31bb470f8e94984a43bea/lib/asker.js#L539) untilerror
orend
event will be fired.Should we fix it? I can change event handler like this