Should asker stop buffering response on request abort?

[doochik]

In some cases data event can be fired after request abort. Asker continues buffering response (https://github.com/nodules/asker/blob/acc28e620c5cf1ef50b31bb470f8e94984a43bea/lib/asker.js#L539) until error or end event will be fired.

Should we fix it? I can change event handler like this

res.on('data', function(chunk) {
    if (httpRequest.rejected) {
        // clear buffer
        // body = [];
        return;
    }

    body.push(chunk);
    bodyLength += chunk.length;
});

[narqo]

Looks like this'll make #92 impossible to implement.

[kaero]

What you mean under "request abort"? Request hasn't a public method to abort a request.

[narqo]

@kaero I believe it's about this peace: https://github.com/nodules/asker/blob/acc28e620c5cf1ef50b31bb470f8e94984a43bea/lib/asker.js#L592-L604

[doochik]

yep

[kaero]

@doochik proposed changes looks acceptable for me, feel free to pr :)

[doochik]

Here it is :) https://github.com/nodules/asker/pull/123

[kaero]

+ asker@1.0.5