search

nodules / asker

http.request wrapper with gzip, request retries and http.Agent tuning
MIT License
93 stars 11 forks source link

Unexpected multipart body encoder behaviour #79

Closed golyshevd closed 10 years ago

golyshevd commented 10 years ago

Hi, there is an issue in multipart body encoder.


        if (isBuffer) {
            data = attach;
        } else if (isFile) {
            data = attach.data;
        } else if (isObject) {
            // Assume, that it's just JS object, not file
            data = new Buffer(JSON.stringify(attach));
        } else {

//   @golyshevd: HERE
            data = new Buffer(attach);
        }

if the attach is a {Number} in body like

{
    id: 42
}

then data will be an empty {Buffer} with attach length. Maybe new Buffer(String(attach)) better?

kaero commented 10 years ago

Hi! Yes, you are right, man.

kaero commented 10 years ago

Degradation test has been added. Test report Version 0.3.2 has been released.