nodules / asker

http.request wrapper with gzip, request retries and http.Agent tuning
MIT License
93 stars 11 forks source link

Asker does not send query on node 0.11.14 #98

Closed golyshevd closed 8 years ago

golyshevd commented 9 years ago

The issue in breaking changes in node's url module

// 0.10.33
url.parse('/', true).query // {}

// 0.11.14
url.parse('/', true).query // null

Here you get null if path option did not contain querysrting but query option is object

kaero commented 9 years ago

Asker has a lot of issues on 0.11 branch of node. We'll test and update it as soon as 0.11.15 (which must be a 0.12 pre-release) come out.

golyshevd commented 9 years ago

Ok, thanks! I don't use node 0.11.*. Just for notice

narqo commented 9 years ago

Looks like everything work as expected in both nodejs-0.12 and nodejs-4:

› 0.12/bin/node --version
v0.12.4
› 0.12/bin/node -p "require('url').parse('/', true).query"
{}

› 4/bin/node --version
v4.1.0
› 4/bin/node -p "require('url').parse('/', true).query"
{}

Guess the issue is out of date now.

narqo commented 8 years ago

Closing as "can't reproduce".