Closed kaero closed 9 years ago
And how about README.md?
And how about README.md?
It will be updated after review, if API changes will be accepted.
:up:
Looks good, as I can tell – :snowflake:
:8ball:
@narqo @ruslankerimov Thanks a lot!
Anybody more? :)
Bunch of v8 optimization bailouts avoided, especially deoptimization of constructors;
Are there any measurements? How much we gonna shave?
@an9eldust
Are there any measurements?
How much we gonna shave?
Nothing, you will be shaved instead! :smirk_cat:
As you can see in the results, the performance of Terror.createError
and Terror
instantiation in general are drastically decreased on node.js 0.10. It's because of usage of Error.catureStackTrace
and stack trace correction in the createError
method to get clean stacktraces. The reason is deoptimizations in v8 internals, which was mostly (but not finally) fixed in the version used for node.js 0.11, where we can see at least the same or higher performance in benchmarks of instantiation.
@an9eldust oh, and there is still one deoptimization in ctor, which caused by v8 issue https://code.google.com/p/v8/issues/detail?id=3167
@an9eldust So all fixes, which we have, helps to don't fall on floor with stacktraces capturing, and make possible to be faster in the future. Sad, but true..
@kaero thx. The rest looks good to me, btw.
@Flackus @miripiruni readme has been updated, review it, plz.
https://github.com/nodules/terror/blob/1.0-dev/README.md
Final countdown for 1.0 :clock10:
:birthday: :smiley_cat:
sup :+1:
When will you publish 1.0.0 package?
@Flackus I've planed to try to integrate new terror into some modules (asker, for example) to test it more, and release the package in the next one or two days.
1.0.0
is finally published!
Significant changes:
Terror#log()
doesn't timestamp messages now, it's a work of the logger;Terror#log()
output formatting has been changed to<level> <code> <message>\n<stacktrace>
;objex
has been thrown out for the reason above;nodeunit
was replaced withmocha
andchai
name
is required now forTerror.create()
calls.C'mon, buddies, lets review it!
\cc @ruslankerimov @Flackus @narqo @an9eldust @isquariel @miripiruni @ZooBestik