1.0 dev

[kaero]

Significant changes:

• No more numeric error codes :smirk:
• Error message now includes messages of all nested errors;
• Stack traces became clean and shiny: no more error constructor calls or empty lines in traces!
• Terror#log() doesn't timestamp messages now, it's a work of the logger;
• Terror#log() output formatting has been changed to <level> <code> <message>\n<stacktrace>;
• Bunch of v8 optimization bailouts avoided, especially deoptimization of constructors;
• objex has been thrown out for the reason above;
• unit testing framework nodeunit was replaced with mocha and chai
• Argument name is required now for Terror.create() calls.

C'mon, buddies, lets review it!

\cc @ruslankerimov @Flackus @narqo @an9eldust @isquariel @miripiruni @ZooBestik

[miripiruni]

And how about README.md?

[kaero]

And how about README.md?

It will be updated after review, if API changes will be accepted.

[kaero]

:up:

[narqo]

Looks good, as I can tell – :snowflake:

[ruslankerimov]

:8ball:

[kaero]

@narqo @ruslankerimov Thanks a lot!

Anybody more? :)

[an9eldust]

Bunch of v8 optimization bailouts avoided, especially deoptimization of constructors;

Are there any measurements? How much we gonna shave?

[kaero]

@an9eldust

Are there any measurements?

Benchmarks code and results

How much we gonna shave?

Nothing, you will be shaved instead! :smirk_cat:

As you can see in the results, the performance of Terror.createError and Terror instantiation in general are drastically decreased on node.js 0.10. It's because of usage of Error.catureStackTrace and stack trace correction in the createError method to get clean stacktraces. The reason is deoptimizations in v8 internals, which was mostly (but not finally) fixed in the version used for node.js 0.11, where we can see at least the same or higher performance in benchmarks of instantiation.

[kaero]

@an9eldust oh, and there is still one deoptimization in ctor, which caused by v8 issue https://code.google.com/p/v8/issues/detail?id=3167

[kaero]

@an9eldust So all fixes, which we have, helps to don't fall on floor with stacktraces capturing, and make possible to be faster in the future. Sad, but true..

[an9eldust]

@kaero thx. The rest looks good to me, btw.

[kaero]

@Flackus @miripiruni readme has been updated, review it, plz.

https://github.com/nodules/terror/blob/1.0-dev/README.md

Final countdown for 1.0 :clock10:

[kaero]

:birthday: :smiley_cat:

[Flackus]

sup :+1:

[Flackus]

When will you publish 1.0.0 package?

[kaero]

@Flackus I've planed to try to integrate new terror into some modules (asker, for example) to test it more, and release the package in the next one or two days.

[kaero]

1.0.0 is finally published!