v1.2.0 - Githubissues

nodules / terror

Base error class which will help you organize errors, generate informative logs and as result grep logs more effectively

MIT License

25 stars 7 forks source link

v1.2.0 #26

Closed kaero closed 9 years ago

kaero commented 9 years ago

fixed Terror.isTerror() → false, was undefined
tests moved from jasmine and expectations to mocha and assertions (to keep it consistent with other nodules)
fixed JSCS rules
avoid usage of Function ctor to create derived constructor to avoid runtime errors in the case of error names which is not a valid JS identifiers. Also it looks like an open door for security issues and crazy hacks.

Published as terror@1.2.0-rc2

Only my changes: https://github.com/nodules/terror/compare/508bea3...v1.2

\cc @narqo @B-Vladi

kaero commented 9 years ago

@narqo I think we can test it in the wild and release if no issues were found.

kaero commented 9 years ago

Minor issue: if nested error is not an instance of Terror, then undefined prepends its error message in the full stack:

>>>>>     undefined SyntaxError: Unexpected token var

The instance of Error has no the property code.

kaero commented 9 years ago

:up:

fixed undefined which prepends messages of non-terror errors in the full stack
different ways of calling the Object#hasOwnProperty reduced to has.call(..)

kaero commented 9 years ago

I've used 1.2.0-rc2 in the dev for app, which uses 1.1.0 and everything looks fine, except undefined in the messages, which i have fixed in 6be8ba3

narqo commented 9 years ago

looks good

vs-kurkin commented 9 years ago

all right