search

nodules / terror

Base error class which will help you organize errors, generate informative logs and as result grep logs more effectively
MIT License
25 stars 7 forks source link

Fix error.stack in nodejs@8 #35

Closed doochik closed 7 years ago

doochik commented 7 years ago

https://nodejs.org/dist/latest-v6.x/docs/api/errors.html#errors_error_message https://nodejs.org/dist/latest-v8.x/docs/api/errors.html#errors_error_message

Changing error.message may not affect error.stack in some cases according to docs. So ensure that all templates are replaced before log.

Flackus commented 7 years ago

Can you please add node@8 to .travis.yml with an according test (if possible)?

doochik commented 7 years ago

@Flackus done. I've added nodejs@8 and fix failed test )

narqo commented 7 years ago

👍

doochik commented 7 years ago

@narqo @Flackus guys, could you release new version?

narqo commented 7 years ago
doochik commented 7 years ago

Thanks a lot!

Flackus commented 7 years ago

@doochik thanks!