search

noeRls / medal-downloader

Download all your public medal videos
MIT License
27 stars 4 forks source link

Large number of clips aren't selected for download #25

Open pa1kia opened 11 months ago

pa1kia commented 11 months ago

When running medal-downloader, not all clips get selected for download. Using the --url argument, this is the response before downloading: "MyUsername have 442 videos, 122 videos downloadable" Using the --password and --username arguments to login, this is the response before downloading: "MyUsername have 442 videos, 154 videos downloadable" This leaves 166 clips missing from the set, without listing them or anything.

My OS is Windows 11 Pro 64bit version 23H2, and I've installed the latest version of Node.js and its dependencies as of this post.

EDIT: Two interesting developments:

  1. The number of videos that actually get downloaded is even less. When downloading by url, it only downloads 121 out of 122 downloadable videos, and when downloading by login, it only downloads 153 out of 154 downloadable videos. This is consistently repeatable, so I don't believe it's due to any temporary network hiccups.
  2. After manually counting the number of clips in my Medal library, I've determined that the total number is actually 153, which is the exact number of videos that were downloaded using my login credentials. This means that medal-downloader actually did work as intended, despite showing information that suggests otherwise. Knowing this only leads me to ask; where does it get any of the above numbers from if my actual clip count is 153?
PlainOlSoapBar commented 11 months ago

I have the same issue. Number of clips detected and downloaded do not line up with how many clips I have. I'm running this on Windows 10 if that somehow helps.

ozcanbilginer commented 11 months ago

I believe medal also counts the clips that you havent uploaded yet, so it looks like you have 422 clips on your profile when you actually have 153. I know its stupid. But i've came across the medal-downloader not downloading some of the clips publicly listed on my profile for some reason. Also if you have the same clip name on several clips only one of them will be downloaded, which is fair but could be more user friendly if the clips were named in a way that is unique while also retaining the original clip names in it. (some metadata alongside the clip name maybe?)

noeRls commented 11 months ago

Thanks for all your contribution!

Do you mind sharing your username @ozcanbilginer or @PlainOlSoapBar so I can debug the issue?

If I summarize, there is two actions items:

  1. Rephrase the output to "MyUsername have 442 videos (uploaded + draft), 154 videos downloadable". So it is easier to understand that the video count also include non uploaded video
  2. Multiple clips with the same name should all be downloaded.

I will fix that when I have some time this month :)

PlainOlSoapBar commented 11 months ago

My username is plainolsoapbar. But my clips are unlisted. I shouldn't have any draft clips, so I don't think that explains the discrepancy in the number of clips it detects or downloads. Good luck with debugging! Thanks.