Closed pho closed 5 months ago
btw. I've been told that sending a PR like this without asking first might not be seen as good etiquette, because it puts pressure on the upstream to accept it since work has already been done
Feel free to drop this if you want! I did this to practice and to be able to install it on my own which I can already do with my fork :)
Hi, thanks for the interest! I don't have experience with Nix packaging. I'll look into it and ponder on it a bit. I have to make up my mind on how I feel about including package specific files in the main repo.
Hi, I've decided not to merge this into the codebase. I'd like to (for the moment at least) keep such packaging details separate from the main codebase and only include things that I fully understand / use / am comfortable maintaining in the long term.
Hi, I just added Nix flake support.
In case you dont know anything about this: Nix (https://nixos.org/) is a package manager, and I did this just because I am using a distro based on it, and with this small change I can have konfyt installed as a package directly from the repository
But if you install nix on other distros this can be useful too, since you can use from the project directory:
$ nix develop
which will drop you in a shell with all the dependencies needed to build the project$ nix build
which should create aresult/bin/konfyt
binary ready to runAnd even from any system you should be able to run it without installing any dependency:
$ nix run github:noedigcode/konfyt
or if you want to test from my current branch:$ nix run github:pho/konfyt/nix
If you wanna learn more about this, please check https://zero-to-nix.com/