noee / mcwsplasmoid

Plasmoid with basic remote control for JRiver MediaCenter Servers using MCWS
MIT License
1 stars 1 forks source link

UI improvements #3

Closed KottV closed 5 years ago

KottV commented 6 years ago

Hi!

While You struggling with cpu eating and polling, I'm appealing you to look in this patch. It does next things:

  1. Turns on native font rendering.
  2. Aligns view to right side.
  3. Aligns buttons and text fields vertically and makes them more readable, especially on tiny panels.
  4. Adds flat buttons option.

mcws_vanilla mcws_my

flat_allign_render.patch.gz

noee commented 6 years ago

Looks good. I think #3 and #4 are already in this next release I'm planning.

I can't seem to read this patch file. Can you send it as a pull request or as a text?

KottV commented 6 years ago

I can't seem to read this patch file. Can you send it as a pull request or as a text?

strange... there late night now, so I'll try make pull request tomorrow, ok?

noee commented 6 years ago

No problem.

KottV commented 6 years ago

https://github.com/noee/mcwsplasmoid/pull/4#issuecomment-384255106

ok, I didn't test with multiple zones

but fonts are still to small default

KottV commented 6 years ago

how it looks with property int pixSize: root.height * 0.3

default

noee commented 6 years ago

Alright, I'll check that too, I'll add a Plasma5 panel so I can see both that and Latte. You're sizing looks weird too, do you have the config option for sizing set to "Size to Number of Zones"?

KottV commented 6 years ago

no unfortunately, it breaks positioning: default

noee commented 6 years ago

Yep, okay, I've been testing with Latte all this time and it behaves much different than standard panels when sizing and positioning. I'll see if I can get a good compromise.

noee commented 6 years ago

Okay, rebase to master and reinstall the plasmoid, it should handle positioning much better now, both Plasma panels and Latte, multi and single zone.

KottV commented 6 years ago

Positioning is nice now, fonts better too. But buttons too small:)

noee commented 6 years ago

Try this one:

mcwsremote-v1.11.99.plasmoid.zip