search

noelboss / featherlight

Featherlight is a very lightweight jQuery lightbox plugin. It's simple yet flexible and easy to use. Featherlight has minimal css and uses no inline styles, everything is name-spaced, it's completely customizable via config object and offers image, ajax and iframe support out of the box. Featherlights small footprint weights about 4kB – in total.
https://www.noevu.ch/featherlight-js-the-ultra-slim-lightbox/
MIT License
2.08k stars 293 forks source link

Printer CSS is broken #342

Closed darkain closed 6 years ago

darkain commented 6 years ago

https://github.com/noelboss/featherlight/commit/5a8d3596a8bb9d9ba19a63c8ea56de01cb77a7a6#diff-ad2dc0999b9a5bcb0bde649fac03da12R157

@page {size: landscape}

This should NOT be applied globally. While it may work for some sites, it absolutely breaks others. For instance, I'm running an ecommerce web site which uses Featherlight to display product images. Updating to the latest version of Featherlight introduced this code, and now I can no longer properly print out customer invoices or shipping labels, because they're all forced into landscape printing.

marcandre commented 6 years ago

Absolutely. Sorry this flew under my radar. Fixed & released.

darkain commented 6 years ago

Thanks!