search

noelboss / featherlight

Featherlight is a very lightweight jQuery lightbox plugin. It's simple yet flexible and easy to use. Featherlight has minimal css and uses no inline styles, everything is name-spaced, it's completely customizable via config object and offers image, ajax and iframe support out of the box. Featherlights small footprint weights about 4kB – in total.
https://www.noevu.ch/featherlight-js-the-ultra-slim-lightbox/
MIT License
2.08k stars 293 forks source link

refactor: remove irrelevant media query #347

Closed Flui closed 6 years ago

Flui commented 6 years ago

As @media all adds nothing, it could be removed. Because when this css is processed by cssnano, all will be removed which leads to a rule that is invalid for Internet Explorer

Flui commented 6 years ago

@noelboss ping

marcandre commented 6 years ago

Thanks for the PR. I have removed the @media all. It's not clear why your commit was removing 19 lines overall, so I didn't use your commit. Let me know if I missed something.

Flui commented 6 years ago

I think removing the media query caused changes in the indentation

marcandre commented 6 years ago

Sure, but the number of lines should have remained the same, or maybe -4 lines for both opening & closing lines. -19 is odd though