search

noeldelgado / gemini-scrollbar

:first_quarter_moon: Custom overlay-scrollbars with native scrolling mechanism for web applications
https://noeldelgado.github.io/gemini-scrollbar/
MIT License
429 stars 63 forks source link

fix autoshow functionality whilst dragging thumb of a scrollbar #23

Closed bkakadiya42 closed 8 years ago

bkakadiya42 commented 8 years ago

this fix will make sure that in autoshow mode, it'll keep showing scrollbar if user moves cursor out of scrollview area horizontally whilst dragging thumb vertically.

noeldelgado commented 8 years ago

Thanks for the pull request @kakadiya91. I took a look to make sure it's ready for merging and found some changes are needed:

.gm-scrollbar-container.gm-autoshow:hover .gm-scrollbar,
.gm-scrollbar-container.gm-autoshow:active .gm-scrollbar {
.gm-scrollbar-container.gm-autoshow:focus .gm-scrollbar {

Should be:

.gm-scrollbar-container.gm-autoshow:hover .gm-scrollbar,
.gm-scrollbar-container.gm-autoshow:active .gm-scrollbar,
.gm-scrollbar-container.gm-autoshow:focus .gm-scrollbar {

Can you please update the pull request to address these?

noeldelgado commented 8 years ago

Thank you @kakadiya91, added in v1.4.1.