noeldelgado / gemini-scrollbar

:first_quarter_moon: Custom overlay-scrollbars with native scrolling mechanism for web applications
https://noeldelgado.github.io/gemini-scrollbar/
MIT License
429 stars 63 forks source link

[Question] e.stopImmediatePropagatio() really need? #55

Closed vlukyanoff closed 6 years ago

vlukyanoff commented 6 years ago

Hi, @noeldelgado!

I can't use mouseDown event on block with gemini scrollbar because gemini call e.stopImmediatePropagation() in _startDrag function. I know, stop propagation isn't best practice, because it changes standart behavios of the browser. Maybe, is there way to avoid stop propogation in this case?

https://github.com/noeldelgado/gemini-scrollbar/blob/88c5d04b24051fb45581bbebe66ad3258ad176d4/index.js#L371

noeldelgado commented 6 years ago

Hi @vlukyanoff, did #56 fix the issue? (v1.5.3)

vlukyanoff commented 6 years ago

Hi @noeldelgado! Yes, it fixed the issue. Thank you!

vlukyanoff commented 6 years ago

@noeldelgado, could you update dependency in https://github.com/noeldelgado/react-gemini-scrollbar please?

Guria commented 6 years ago

I would be great if gemini-scrollbar were peerDependency of react-gemini-scrollbar to avoid such update needs.

noeldelgado commented 6 years ago

@vlukyanoff done, thanks!