search

noeldelgado / gemini-scrollbar

:first_quarter_moon: Custom overlay-scrollbars with native scrolling mechanism for web applications
https://noeldelgado.github.io/gemini-scrollbar/
MIT License
429 stars 63 forks source link

perf(minify): minify CSS and JavaScript #61

Open Kristinita opened 6 years ago

Kristinita commented 6 years ago

1. Summary

I minify index.js and gemini-scrollbar.css.

2. Argumentation

3. Environment

I minify files use default settings of this minifiers:

Thanks.

Kristinita commented 5 years ago

@noeldelgado , ping.

Thanks.

Kristinita commented 3 years ago

Type: Additional arguments ➕

@noeldelgado, I’m not sure, that ignoring pull requests is the best strategy.

CDN

Yes, jsDelivr can automatically minify files. Example — https://cdn.jsdelivr.net/npm/gemini-scrollbar@1.5.3/index.min.js. But:

  1. Other services may not automatically minify files.

  2. See the comment of jsDelivr founder:

    Yes, we do minify manually some files but the difference is that we can check for validity. The bot cant do that, it will simply upload the output of the tool.

    And we still prefer to ask the authors to include official minified files to remove all responsibility from us.

    Ideally we want to enable auto-updates on all projects and have all authors include minified files.

Thanks.