Open Kristinita opened 3 years ago
@noeldelgado, please add finally this line:
obj.textContent = 'Resize trigger';
Thanks.
Type: Update ⬆
@noeldelgado, please review the changes.
I have updated my changes:
- obj.textContent = 'Resize trigger';
+ obj.setAttribute('aria-label', 'Resize trigger');
For Lighthouse 11.4.0 obj.textContent = 'Resize trigger';
ceased to be valid. Lighthouse 11.4.0 links to the Deque University article where the problem <object> elements must have alternate text
is solved as follows:
Add alternative text to all embedded
<object>
elements using eitheraria-label
,aria-labelledby
, ortitle
attributes.
Default index.js
file, https://cdn.jsdelivr.net/npm/gemini-scrollbar/index.js:
My previous changes, https://cdn.jsdelivr.net/gh/Kristinita/gemini-scrollbar@fd4400bd136ae02e34d94db3d0570d8ebce7acf1/index.js:
My current changes, https://cdn.jsdelivr.net/gh/Kristinita/gemini-scrollbar@KiraPatchObjectAltText/index.js:
Thanks.
1. Changes
.gm-resize-trigger
object.index.js
use UglifyJS.2. Argumentation
2.1. Summary
For successful lighthouse validation.
2.2. Details
<object>
elements do not have [alt] text<object>
elements must have alternate text3. Steps to reproduce
I opened pages with Gemini Scrollbar in Chromium:
→ I ran lighthouse from Chrome DevTools → see below parts of lighthouse reports.
4. Behavior
4.1. Before
Object from DevTools Elements panel:
Part of lighthouse report:
4.2. After
Object from DevTools Elements panel:
Part of lighthouse report:
5. Techniques used
Node.textContent
.Internet Explorer 8 doesn’t support it, but Gemini Scrollbar supports IE9+. Another browsers must successfully support
Node.textContent
.6. Testing environment
--disable-extensions
flag.Thanks.