RoR group project: set up your Kanban board

Kccendana commented 11 months ago

Team Members: 2 @noelfoka @Kccendana

Ibizugbe commented 11 months ago

Hi @Kccendana @noelfoka 👋🏼👋🏼👋🏼,

request change

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights✅✅✅

[x] Link to the project has been provided👍🏼.
[x] Name of team members has been provided 👍🏼.
[x] The project board contains the appropriate columns as required👍🏼.

Required Changes ♻️

[ ] Kindly ensure all cards (tasks) are assigned points. currently, one of your cards doesn't have any point assigned to it😉. Kindly fix that👍🏼. Kindly ensure all cards have points assigned to them👍🏼.
[ ] Kindly ensure all requirements are captured in your project board😉. you currently haven't captured the n+1 requirement😉. Kindly do well to make changes as regards that👍🏼.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

noelfoka commented 11 months ago

It is done we are resolve them

DammyShittu commented 11 months ago

Hi @Kccendana and @noelfoka,

APPROVED 🟢

Highlights

✔️ All tasks are present

Great implementation of all the requirements in this milestone. 👏

You have done an amazing job 👍

Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:

Congratulations! 🎉

CHEERS AND HAPPY CODING!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

noelfoka / Recipe-App-RoR