Issues in v2.1.xx - Githubissues

edo-jan commented 3 months ago

Issue #1: Bookmarks view in Koreader incorrectly shows annotations after reverse sync To replicate:

Use Highlights view in KH to delete a few annotations (but not the highlight).
1. Reverse sync the archved view back to the devices
2. On the devices in the bookmarks the deleted annotations will show as blanks (see screenshot)

edo-jan commented 3 months ago

Re: Issue 1 above: If the blank annotation is then opened on the device - it will show no characters in it. If one applies "save" then the blank pensil is replaced with the underlying highlight text (the expected)

noembryo commented 3 months ago

Use Highlights view in KH to delete a few annotations (but not the highlight).

I think that you have misunderstood some of the terms we're using, and that leads to my confusion about what is happening. I'll try to clarify some meanings.

Bookmark: the info about a page of a book (shows a dogear at the top right of the page, not seen inside KOHighlights)
Highlight: the info about a part of a text in a book (highlighted on the reader, can be deleted from within KOHighlights)
Comment/Note: info about a highlight (can be edited/deleted within KOHighlights)
Annotation: either a Highlight or a Bookmark (the key that all highlights and bookmarks are stored in the "new" metadata is called "annotations")

To make things more complicated, KOReder has only one place to access highlights and bookmarks, and it's called "Bookmarks".

So, in light of all this, you have to explain to me again how you can delete a few annotations but not the highlight, because I don't believe it's possible. Try to be more specific with all the steps..

Also keep in mind that this is the last day with my PC, and after this, it will be a while until I can work in this again..

edo-jan commented 3 months ago

So, in light of all this, you have to explain to me again how you can delete a few annotations but not the highlight, because I don't believe it's possible. Try to be more specific with all the steps..

In light of the clarification provided, I deleted Comments/notes associated with highlights. For context, a while back there was a weird bug in Koreader (got fixed eventually) which created Comments/Notes on blank highlights. Essentually, it would put the text of the highlight into the comment/note. These "notes" I manually deleted from KH. and synced it back to the devices. The result you see on the screenshot above.

Also keep in mind that this is the last day with my PC, and after this, it will be a while until I can work in this again..

Noted. For how long are you going to be away?

noembryo commented 3 months ago

OK, see the problem now. I can fix it before I leave..

For how long are you going to be away?

Not sure, depends. From a couple of weeks to a month?

noembryo commented 3 months ago

Fixed in v2.1.1.0..

noembryo / KoHighlights

Issues in v2.1.xx #39